[RFC/RFT PATCH] net: stmmac: do not poke MAC_CTRL_REG twice on link up
Heiner Kallweit
hkallweit1 at gmail.com
Mon Aug 29 11:25:05 PDT 2022
On 29.08.2022 12:29, Erico Nunes wrote:
> On Mon, Aug 29, 2022 at 12:02 PM Jerome Brunet <jbrunet at baylibre.com> wrote:
>>>>> Jerome, can you confirm that after this commit the following is no longer needed?
>>>>> 2c87c6f9fbdd ("net: phy: meson-gxl: improve link-up behavior")
>>
>> This never had any meaningful impact for me. I have already reverted it
>> for testing.
>>
>> I'm all for reverting it
>>
>>>>>
>>>>> Then I'd revert it, referencing the successor workaround / fix in stmmac.
> If we are considering to revert that, I would like to trigger some
> tests on my S805X CI board farm as well, to ensure it won't regress
> later. That was one of the original reasons for that patch.
>
> Since there are some more changes referenced in this thread, can
> someone clarify what is the desired state to test? Just revert
> 2c87c6f9fbdd on top of linux-next, or also apply some other patch?
Yes, just revert 2c87c6f9fbdd on top of linux-next.
More information about the linux-amlogic
mailing list