[PATCH v1 0/3] ASoC: meson: Fix mixer-test issues

Jerome Brunet jbrunet at baylibre.com
Thu Apr 21 06:02:54 PDT 2022


On Thu 21 Apr 2022 at 13:38, Mark Brown <broonie at kernel.org> wrote:

> These patches fix event generation issues in the custom controls in the
> Meson drivers detected by mixer-test and by inspection once I saw the
> pattern in these drivers.

Reviewed-by: Jerome Brunet <jbrunet at baylibre.com>

Thx !

> I'm also seeing other failures due to these
> controls having invalid values, eg:
>
> # # AIU ACODEC SRC.0 value 3 more than item count 3
>
> but without documentation I'm not sure how to interpret/fix these -
> either the value should be fixed up on startup or there should be an
> extra value there (disconnected possibly?).

Value 3 is an I2S input from a block we don't support.
If we did support it, it would be an hostless DPCM BE to BE link
I'm not sure how I would represent this in ASoC TBH :/

At the time, I thought it would be easier (for the users) to leave this
value out and not give the false impression that the path was somehow
supported.

I did not realize it was the reset value nor that it would be a problem.

I can add a element to the enum if you think it is better have it
regardless of the actual path support. What do you think ?

>
> Mark Brown (3):
>   ASoC: meson: Fix event generation for AUI ACODEC mux
>   ASoC: meson: Fix event generation for AUI CODEC mux
>   ASoC: meson: Fix event generation for G12A tohdmi mux
>
>  sound/soc/meson/aiu-acodec-ctrl.c | 2 +-
>  sound/soc/meson/aiu-codec-ctrl.c  | 2 +-
>  sound/soc/meson/g12a-tohdmitx.c   | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
>
> base-commit: 3123109284176b1532874591f7c81f3837bbdc17




More information about the linux-amlogic mailing list