[PATCH] arm64: dts: meson-sm1: add spdifin spdifout nodes
Jerome Brunet
jbrunet at baylibre.com
Mon Sep 6 02:25:32 PDT 2021
On Thu 02 Sep 2021 at 15:31, Neil Armstrong <narmstrong at baylibre.com> wrote:
> Hi,
>
> On 11/08/2021 07:09, Artem Lapkin wrote:
>> Add spdifin spdifout spdifout_b nodes for Amlogic SM1 SoCs.
>>
>> Signed-off-by: Artem Lapkin <art at khadas.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-sm1.dtsi | 40 ++++++++++++++++++++++
>> 1 file changed, 40 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
>> index 3d8b1f4f2..1efdbb61e 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1.dtsi
>> @@ -356,6 +356,33 @@ tdmin_lb: audio-controller at 3c0 {
>> status = "disabled";
>> };
>>
>> + spdifin: audio-controller at 400 {
>> + compatible = "amlogic,g12a-spdifin",
>> + "amlogic,axg-spdifin";
>> + reg = <0x0 0x400 0x0 0x30>;
>> + #sound-dai-cells = <0>;
>> + sound-name-prefix = "SPDIFIN";
>> + interrupts = <GIC_SPI 151 IRQ_TYPE_EDGE_RISING>;
>> + clocks = <&clkc_audio AUD_CLKID_SPDIFIN>,
>> + <&clkc_audio AUD_CLKID_SPDIFIN_CLK>;
>> + clock-names = "pclk", "refclk";
>> + resets = <&clkc_audio AUD_RESET_SPDIFIN>;
>> + status = "disabled";
>> + };
>> +
>> + spdifout: audio-controller at 480 {
>> + compatible = "amlogic,g12a-spdifout",
>> + "amlogic,axg-spdifout";
>> + reg = <0x0 0x480 0x0 0x50>;
>> + #sound-dai-cells = <0>;
>> + sound-name-prefix = "SPDIFOUT";
>> + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT>,
>> + <&clkc_audio AUD_CLKID_SPDIFOUT_CLK>;
>> + clock-names = "pclk", "mclk";
>> + resets = <&clkc_audio AUD_RESET_SPDIFOUT>;
>> + status = "disabled";
>> + };
>> +
>> tdmout_a: audio-controller at 500 {
>> compatible = "amlogic,sm1-tdmout";
>> reg = <0x0 0x500 0x0 0x40>;
>> @@ -401,6 +428,19 @@ tdmout_c: audio-controller at 580 {
>> status = "disabled";
>> };
>>
>> + spdifout_b: audio-controller at 680 {
>> + compatible = "amlogic,g12a-spdifout",
>> + "amlogic,axg-spdifout";
>> + reg = <0x0 0x680 0x0 0x50>;
>> + #sound-dai-cells = <0>;
>> + sound-name-prefix = "SPDIFOUT_B";
>> + clocks = <&clkc_audio AUD_CLKID_SPDIFOUT_B>,
>> + <&clkc_audio AUD_CLKID_SPDIFOUT_B_CLK>;
>> + clock-names = "pclk", "mclk";
>> + resets = <&clkc_audio AUD_RESET_SPDIFOUT_B>;
>> + status = "disabled";
>> + };
>> +
>> toacodec: audio-controller at 740 {
>> compatible = "amlogic,sm1-toacodec",
>> "amlogic,g12a-toacodec";
>>
>
> Jerome could you quickly review this ?
>
Just this, without the related card change is not usefull as it won't be
part of the card.
It would be nice to indicate how it was tested ?
AFAIK:
- spdifout b can only be routed to hdmi and dw-hdmi driver does not
support that yet
- the VIM3 does not have connectors for the spdif (in or out). If it
requires some extension card, it should be noted somewhere, at least
> Thanks,
> Neil
More information about the linux-amlogic
mailing list