[RFC PATCH v1] pinctrl: meson: meson8b: fix requesting GPIOs greater than GPIOZ_3

Linus Lüssing linus.luessing at c0d3.blue
Wed Jan 24 20:03:31 PST 2018

On Wed, Jan 24, 2018 at 01:27:38AM +0100, Martin Blumenstingl wrote:
> Meson8b's AO GPIO controller is not affected by this issue since it does
> not have any holes in it - only the CBUS GPIO controller is affected.
> This was initially seen by Linus Lüssing who was preparing SD card
> support on Odroid-C1 which uses CARD_6 as "card detect" GPIO.
> Fixes: db80f0e158e621 ("pinctrl: meson: get rid of unneeded domain structures")
> Reported-by: Linus Lüssing <linus.luessing at c0d3.blue>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>

Hi Martin,

Just wanted to confirm that this indeed fixes the splats and
crashes I was experiencing. And I was able to successfully
read/write from/to a microSD card. Also card detect worked fine, I
could successfully unplug, replug and then read from it again.
Here some dmesg from a successful card detection:

[  512.584687] mmcblk0: error -84 sending status command, retrying
[  512.586985] mmcblk0: timed out sending r/w cmd command, card status 0xd00
[  512.591756] mmcblk0: status not valid, retrying timeout
[  638.652986] mmc0: card 1234 removed
[  656.722455] mmc0: new high speed SDHC card at address 1234
[  656.724667] mmcblk0: mmc0:1234 SA16G 14.4 GiB 
[  656.730312]  mmcblk0: p1 p2

There error happened when typing "$ sync" after the write. However
the written file seemed fine in the end.

The address 1234 also seemed like a weird coincidence. But maybe
that's just a bug in my DT changes.

I'll post the DT changes I had been experimenting with as an RFC
to linux-amlogic shortly.

Regards, Linus

More information about the linux-amlogic mailing list