[PATCH 1/2] ARM: dts: meson8b: extend ethernet controller description

[Jerome Brunet]

On Tue, 2018-01-16 at 11:41 +0100, Martin Blumenstingl wrote:
> > >   &ethmac {
> > > -     clocks = <&clkc CLKID_ETH>;
> > > -     clock-names = "stmmaceth";
> > > +     compatible = "amlogic,meson8b-dwmac", "snps,dwmac-3.70a", "snps,dwmac";
> > 
> > Does meson8 shared the same IP block ? is yes, then this compatible should
> > probably be changed one level up, along with the regs
> > 
> > If not, it means that ethmac node should not be defined in meson.dtsi but in
> > meson8.dtsi and meson8b.dtsi
> 
> it's tricky - I have ordered a Meson8 board (which has not arrived
> yet), but according to my findings:
> - Meson6 uses the old binding
> - Meson8 uses the same binding as Meson6
> - Meson8b uses the new binding / same binding as GXBB
> - Meson8m2 (which is mostly identical to Meson8) uses the same binding
> as Meson8b / GXBB
> 
> > In any case, overloading the node like this really clean, even if it works.
> 
> my plan is to restructure the ethmac node once I have my Meson8 board:
> - add the the "amlogic,meson6-dwmac" compatible and the 0xc1108108
> register to meson6.dtsi and meson8.dtsi
> - remove the "amlogic,meson6-dwmac" binding from meson.dtsi
> - figure out whether meson8m2.dtsi (upcoming, on my TODO-list...)
> should inherit meson8.dtsi or meson.dtsi
> 
> some more context:
> Meson8 and Meson8m2 share a lot of functionality:
> - SMP / CPU hotplug procedure
> - CPU frequencies (OPP tables)
> - pinctrl
> however, there are some differences too:
> - Meson8m2 uses the WDT layout from Meson8b
> - Meson8m2 uses the same CPU temperature calibration procedure as Meson8b
> - (not tested yet) Meson8m2 uses the Ethernet registers from Meson8b
> 
> in other words:
> I think it's a good idea to restructure the ethmac node
> however, I would prefer to do it outside of this series so we don't
> have to do it twice (once with limited testing, then fixing some bugs
> in a follow-up series once I could test it on Meson8)

Sounds like a plan. Fine by me.
It's up to Kevin now ;)