[PATCH v4 05/10] i2c: meson: use full 12 bits for clock divider

Heiner Kallweit hkallweit1 at gmail.com
Thu Mar 23 23:49:04 PDT 2017


Am 23.03.2017 um 21:34 schrieb Wolfram Sang:
> 
>> +	/* clock divider has 12 bits */
>> +	WARN_ON(div >= (1 << 12));
> 
> Do you insist on WARN_ON? I wonder what it gives over dev_err?
> 
Right, as we just read the bus frequency from DT there's not
really a benefit in seeing the call trace. I'll change it.




More information about the linux-amlogic mailing list