[PATCH 1/3] devicetree: add vendor prefix for Khadas

Andreas Färber afaerber at suse.de
Wed Mar 15 23:00:55 PDT 2017


Am 15.03.2017 um 20:57 schrieb Rob Herring:
> On Sat, Mar 04, 2017 at 10:51:24PM +0100, Martin Blumenstingl wrote:
>> Khadas is a new sub-brand of Shenzhen Wesion Technology CO.,LTD. They
>> are developing Amlogic and Rockchip based "DIY boxes" (single board
>> computers): http://khadas.com/
>> They are best know for their latest product: the Khadas VIM (an Amlogic
>> GXL S905X based SBC).
>>
>> Signed-off-by: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
>> ---
>>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>>  1 file changed, 1 insertion(+)
> 
> Acked-by: Rob Herring <robh at kernel.org>

Shouldn't the entry reflect what is in the commit message rather than
just repeat the prefix? I.e., something like "Khadas by Shenzhen Wesion
Technology Co., Ltd." (which I believe is the official spelling and
spacing of these abbreviations also for the commit message).

An Acked-by from the CC'ed vendor would also be desirable. :)

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)



More information about the linux-amlogic mailing list