[PATCH v3 1/10] mmc: meson-gx: simplify bounce buffer setting in meson_mmc_start_cmd

Kevin Hilman khilman at baylibre.com
Fri Mar 3 10:17:07 PST 2017


Heiner Kallweit <hkallweit1 at gmail.com> writes:

> Am 01.03.2017 um 19:09 schrieb Kevin Hilman:
>> Hi Heinar,
>> 
>> Heiner Kallweit <hkallweit1 at gmail.com> writes:
>> 
>>> Core ensures that there are no commands with cmd->data being set and
>>> nothing to transfer. And we don't have to reset bit CMD_CFG_DATA_NUM
>>> because cmd_cfg was zero-initialized and this bit isn't set.
>>>
>>> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>
>>> Acked-by: Kevin Hilman <khilman at baylibre.com>
>> 
>> Could you send this series one more time, collecting the remaining tags
>> and including the patches from Michał Zegan?
>> 
> Patchwork tracks all the tags coming in for a patch, there it's visible
> that you acked my 10 patches + the two from Michal.

Yes, I'm well aware of how patchwork works, yet my request still stands.

> So I would leave it up to Ulf whether he prefers to have the series
> re-sent (with just the few remaining acks as changes).

That's your choice, but some friendly advice from a kernel maintainer:
making things as easy as possible for maintainers/reviewers greatly
improves speed your code will get merged.

Kevin



More information about the linux-amlogic mailing list