[PATCH] clk: meson: fix SET_PARM macro
Kevin Hilman
khilman at baylibre.com
Tue Feb 28 10:04:05 PST 2017
Jerome Brunet <jbrunet at baylibre.com> writes:
> parameter val is not enclosed in parenthesis which is buggy when given an
> expression instead of a simple value
>
> Signed-off-by: Jerome Brunet <jbrunet at baylibre.com>
Reviewed-by: Kevin Hilman <khilman at baylibre.com>
> ---
> drivers/clk/meson/clkc.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/clkc.h b/drivers/clk/meson/clkc.h
> index 9bb70e7a7d6a..c6be77dd8694 100644
> --- a/drivers/clk/meson/clkc.h
> +++ b/drivers/clk/meson/clkc.h
> @@ -25,7 +25,7 @@
> #define PARM_GET(width, shift, reg) \
> (((reg) & SETPMASK(width, shift)) >> (shift))
> #define PARM_SET(width, shift, reg, val) \
> - (((reg) & CLRPMASK(width, shift)) | (val << (shift)))
> + (((reg) & CLRPMASK(width, shift)) | ((val) << (shift)))
>
> #define MESON_PARM_APPLICABLE(p) (!!((p)->width))
More information about the linux-amlogic
mailing list