[PATCH 08/18] mmc: meson-gx: make two functions return void

Kevin Hilman khilman at baylibre.com
Wed Feb 15 09:18:28 PST 2017


Heiner Kallweit <hkallweit1 at gmail.com> writes:

> The return value of meson_mmc_request_done and meson_mmc_read_resp
> isn't used, so make both functions return void.
>
> Signed-off-by: Heiner Kallweit <hkallweit1 at gmail.com>

Acked-by: Kevin Hilman <khilman at baylibre.com>

> ---
>  drivers/mmc/host/meson-gx-mmc.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index f3963538..a67c811e 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -421,7 +421,8 @@ static void meson_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
>  			__func__, orig, val);
>  }
>  
> -static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
> +static void meson_mmc_request_done(struct mmc_host *mmc,
> +				   struct mmc_request *mrq)
>  {
>  	struct meson_host *host = mmc_priv(mmc);
>  
> @@ -430,8 +431,6 @@ static int meson_mmc_request_done(struct mmc_host *mmc, struct mmc_request *mrq)
>  	host->mrq = NULL;
>  	host->cmd = NULL;
>  	mmc_request_done(host->mmc, mrq);
> -
> -	return 0;
>  }
>  
>  static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
> @@ -537,7 +536,7 @@ static void meson_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
>  	meson_mmc_start_cmd(mmc, mrq->cmd);
>  }
>  
> -static int meson_mmc_read_resp(struct mmc_host *mmc, struct mmc_command *cmd)
> +static void meson_mmc_read_resp(struct mmc_host *mmc, struct mmc_command *cmd)
>  {
>  	struct meson_host *host = mmc_priv(mmc);
>  
> @@ -549,8 +548,6 @@ static int meson_mmc_read_resp(struct mmc_host *mmc, struct mmc_command *cmd)
>  	} else if (cmd->flags & MMC_RSP_PRESENT) {
>  		cmd->resp[0] = readl(host->regs + SD_EMMC_CMD_RSP);
>  	}
> -
> -	return 0;
>  }
>  
>  static irqreturn_t meson_mmc_irq(int irq, void *dev_id)



More information about the linux-amlogic mailing list