[PATCH] Core: Add get_version() call

Pete Batard pete at akeo.ie
Wed Apr 11 10:59:37 EDT 2012


On 2012.04.11 04:42, Michael Plante wrote:
> The libusb_speed enum definition appears to be whitespace only.

See the commit message from [1]:
* Also some formatting/typo improvements

I find the idea that simple formatting/typos should require a separate 
commit rather idiotic, especially as, unlike what is the case for 
libusb, libusbx commits are not going to be reverted. And I'm still 
waiting for someone to point to an example where piggybacking on a 
commit to add trivial fixes has produced disastrous results.

Or do you see actual breakage in enum libusb_speed?
All the patches I checked display the expected bunch of spaces having 
been replaced by tabs, to harmonize with what we have in other enums, so 
I really fail to see an actual problem there.

> I really can't reasonably react that fast,

Noone expects you to. If you're around and want to review great. If 
you're not or are busy that's fine too.

> so I'm not sure what the point is to posting patches to the list.

Well the patch was reviewed and acked by another maintainer.

> I guess the policy is to leave it now?

I still don't understand your problem. Please elaborate.

Regards,

/Pete


[1] 
http://libusbx.git.sourceforge.net/git/gitweb.cgi?p=libusbx/libusbx;a=commitdiff;h=37dfd16c8c2f36c81c86de303072def0dc405e32



More information about the libusbx mailing list