icalfileset_fetch

Allen Winter winter at kde.org
Thu Feb 18 12:14:20 PST 2016


On Thursday, February 18, 2016 01:02:47 PM libical at esumsoft.com wrote:
> Hi,
> 
> I just started using libical (v2.0.0) a couple of days ago, so I'm still getting a feel for it, but I came across some questionable behavior.
> 
> In the function icalfileset_fetch() (icalfileset.c) the value returned is "this" but shouldn't it be "inner" ?
> 
> That is, instead of:
>                 if (strcmp(uid, this_uid) == 0) {
>                     return this;
>                 }
> 
> It should be:
>                 if (strcmp(uid, this_uid) == 0) {
>                     return inner;
>                 }
> 
> In the current implementation, searching for the uid of a VEVENT will return the VCALENDAR component instead of the VEVENT.  Or is this intentional?
> 
I'll take a look.
I don't know that anyone has been actively mucking around in icalfileset for many years
so most likey not-intentional.

If you happen to have some test code we could use to verify and add to our test suite
I would be happy to have it.

-Allen





More information about the libical-devel mailing list