[PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()
SF Markus Elfring
elfring at users.sourceforge.net
Sat Jan 2 00:09:23 PST 2016
>> Move the jump label directly before the desired log statement
>> so that the variable "err" will not be checked once more
>> after it was determined that a function call failed.
>> Use the identifier "report_failure" instead of the label "err".
I suggest to reconsider the places with which such a jump label
> The code was smart enough
Which action should really be performed after a failure was detected
and handled a bit already?
* Another condition check
* Just additional error logging
> and you're making it uglier that it needs to be.
I assume that a software development taste can evolve, can't it?
More information about the libertas-dev