[PATCH] net-libertas: Better exception handling in if_spi_host_to_card_worker()

Sergei Shtylyov sergei.shtylyov at cogentembedded.com
Fri Jan 1 15:14:46 PST 2016


On 1/2/2016 12:33 AM, SF Markus Elfring wrote:

> From: Markus Elfring <elfring at users.sourceforge.net>
> Date: Fri, 1 Jan 2016 22:27:20 +0100
> This issue was detected by using the Coccinelle software.
> Move the jump label directly before the desired log statement
> so that the variable "err" will not be checked once more
> after it was determined that a function call failed.
> Use the identifier "report_failure" instead of the label "err".

    Why? The code was smart enough and you're making it uglier that it needs 
to be.

> Signed-off-by: Markus Elfring <elfring at users.sourceforge.net>

MBR, Sergei

More information about the libertas-dev mailing list