[LEDE-DEV] [PATCH netifd] proto: allow dumping protocol handlers without config_params

[Hans Dedecker]

On Thu, Jan 4, 2018 at 9:01 AM, Olof Sivertsson <osivertsson at gmail.com> wrote:
> Hi Hans,
>
>>
>> I'm unable to reproduce the reported netifd crash by using a proto
>> shell handler having no proto_init_config function.
>> Looking into the code the proto_handler config_params parameter is
>> always assigned the proto shell handler config pointer in the function
>> proto_shell_add_handler; afaict the config_parameter is not altered
>> further in the code.
>> Can you describe how you triggered the crash using a proto shell
>> handler implementation ?
>
>
> Sorry for not giving the full background.
>
> Our customers have security requirements that makes shell-based protocol
> handlers a hard sell.
> We have instead written a custom non-shell DHCP protocol handler, inspired
> by proto-static.c, and with no use for config_params it was set to NULL.
>
> It is working well, and the case with config_params = NULL seems to be
> handled elsewhere in the code, e.g. in config.c.
> Therefore we assumed that it should be handled everywhere, and hence this
> patch.
Thanks for giving the background; the patch makes definitely sense as
config_params is checked for NULL in other places as you point out. I
was just wondering what I was missing since I could not reproduce the
issue.

Hans
>
> -Olof Sivertsson
>