[LEDE-DEV] [PATCH netifd] proto: allow dumping protocol handlers without config_params

Jo-Philipp Wich jo at mein.io
Wed Jan 3 13:24:29 PST 2018


Hi,

> I'm unable to reproduce the reported netifd crash by using a proto
> shell handler having no proto_init_config function.
> Looking into the code the proto_handler config_params parameter is
> always assigned the proto shell handler config pointer in the function
> proto_shell_add_handler; afaict the config_parameter is not altered
> further in the code.
> Can you describe how you triggered the crash using a proto shell
> handler implementation ?

That being said, I still think that the change is sensible. Even if the
root cause turns out to be something else.

~ Jo



More information about the Lede-dev mailing list