[LEDE-DEV] [PATCH 2/3] ag71xx: Remove ___cacheline_aligned from ring structs.

[Florian Fainelli]

On February 6, 2018 2:27:29 PM PST, Rosen Penev <rosenp at gmail.com> wrote:
>Qualcomm's struct members and inner workings of their driver are all
>different.
>While this might make sense for their driver, it seems to hurt here. In
>iperf3, i've seen inconsistent results including a drop of 100mbps on
>an
>Archer C7v4. This patch keeps the results high and relatively
>consistent.
>
>Signed-off-by: Rosen Penev <rosenp at gmail.com>

Do you use pahole to get a view of how the structure members are aligned and if there is room for reducing the holes and/or moving hot/frequently accessed members to a cache line aligned offset within the structure? If not, I would highly recommend using it and possibly providing the output before and after to show the improvement.

-- 
Florian