[LEDE-DEV] [PATCH 1/2] libubox: Don't warn about sign comparisons.

[Rosen Penev]

On Fri, Feb 2, 2018 at 9:38 AM, Karl Palsson <karlp at tweak.net.au> wrote:
>
> Rosen Penev <rosenp at gmail.com> wrote:
>> On Fri, Feb 2, 2018 at 4:54 AM, Karl Palsson
>> <karlp at tweak.net.au> wrote:
>> >
>> > Rosen Penev <rosenp at gmail.com> wrote:
>> >> -Wsign-compare was breaking my builds when i disabled MIPS16 on
>> >> ramips (mt7621). Since this will probably not get fixed,
>> >> disable it.
>> >
>> > Given the fine tuned nature of all your prior commits, why are
>> > you now all of a sudden avoiding actually fixing the bad sign
>> > comparisons?
>>
>> It breaks my build. Previous efforts at fixing have been
>> unsuccessful.
>
> link to rejected patches that fix it?

https://patchwork.ozlabs.org/patch/741841/

Not rejected but no activity. Nobody cares.

> Sounds like it would be
> easier to push on a "this doesn't compile" than just "let's turn
> off warnings"

Except -Wextra is getting added by something. It's not part of
libubox' CFLAGS. AFAIK (away from home so can't check) the other
-Wextra warning that gets triggered is -Wunused-parameter which is
explicitly ignored by the build system with -Wno-unused-parameter.

>
> Cheers,
> Karl Palsson