[LEDE-DEV] [PATCH 1/2] libubox: Don't warn about sign comparisons.

[Karl Palsson]

Rosen Penev <rosenp at gmail.com> wrote:
> On Fri, Feb 2, 2018 at 4:54 AM, Karl Palsson
> <karlp at tweak.net.au> wrote:
> >
> > Rosen Penev <rosenp at gmail.com> wrote:
> >> -Wsign-compare was breaking my builds when i disabled MIPS16 on
> >> ramips (mt7621). Since this will probably not get fixed,
> >> disable it.
> >
> > Given the fine tuned nature of all your prior commits, why are
> > you now all of a sudden avoiding actually fixing the bad sign
> > comparisons?
> 
> It breaks my build. Previous efforts at fixing have been
> unsuccessful.

link to rejected patches that fix it? Sounds like it would be
easier to push on a "this doesn't compile" than just "let's turn
off warnings"

Cheers,
Karl Palsson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.html
Type: application/pgp-signature
Size: 1161 bytes
Desc: OpenPGP Digital Signature
URL: <http://lists.infradead.org/pipermail/lede-dev/attachments/20180202/6c43b2c3/attachment.sig>