[LEDE-DEV] [PATCH 1/5] tools/zlib: move zlib build to tools

[Hauke Mehrtens]

On 04/18/2018 09:44 AM, Lucian Cristian wrote:
> On 18.04.2018 01:24, Koen Vandeputte wrote:
>>
>>
>> On 17-04-18 19:16, Lucian Cristian wrote:
>>> On 16.04.2018 01:53, Hauke Mehrtens wrote:
>>>> This allows us to link the other tools against our libz and we do not
>>>> need the system zlib any more.
>>>>
> [...]
>>>> +endef
>>>> +
>>>> +$(eval $(call HostBuild))
>>>
>>> I tested the patch series because I have a linking problem with zlib
>>> and python an I wanted to see if this fixes it (it does not) but on
>>> i686 I have this error
>>>
>>>
>>> make[8]: Entering directory
>>> '/home/build/proxy/build_dir/hostpkg/glib-2.56.1/gio'
>>>   CCLD     libgio-2.0.la
>>> /usr/bin/ld:
>>> /home/build/proxy/staging_dir/host/lib/libz.a(deflate.o): relocation
>>> R_X86_64_PC32 against symbol `_length_code' can not be used when
>>> making a shared object; recompile with -fPIC
>>> /usr/bin/ld: final link failed: Bad value
>>> collect2: error: ld returned 1 exit status
>>> Makefile:2183: recipe for target 'libgio-2.0.la' failed
>>>
>>>
>> Hi Hauke,
>>
>> Probably related to the above?
>>
>> When I'm building using this patch series, I'm getting a python build
>> error.
>> Please see attached logfile.
>> Reverting the series fixes the build issue.
>>
>>
>> Do note that I'm also using my own config, which adds all feeds and
>> uses a lot more packages than default OpenWrt.
>>
>> Thanks,
>>
>> Koen
> 
> /usr/bin/ld:
> /mnt/ramdisk/test/firmware/builds/generic_imx6/staging_dir/host/lib/libz.a(crc32.o):
> relocation R_X86_64_32S against `.rodata' can not be used when making a
> shared object; recompile with -fPIC
> /mnt/ramdisk/test/firmware/builds/generic_imx6/staging_dir/host/lib/libz.a:
> error adding symbols: Bad value
> collect2: error: ld returned 1 exit status
> 
> I looked in Makefile and there is TARGET_CFLAGS += $(FPIC) so it means
> it should already have -fPIC ?
> 

H,

I fixed the build error in glib2 by adding a -fPIC host cflag to the zlib.

Hauke