[LEDE-DEV] using sata-port-specific led triggers

[Daniel Golle]

Hi Alberto,

On Wed, Mar 08, 2017 at 09:59:10PM +0000, Alberto Bursi wrote:
> Hi, I'm trying to use the functionality added by this patch [1] (it 
> should generate different led triggers for each Sata port) for a few 
> kirkwood device that have multiple Sata Leds.
> 
> This patch is currently used only by some oxnas NAS devices, that seem 
> to have not been fully ported to device tree.
> 
> After reading its description and the oxnas files I have added
> 
> CONFIG_ARCH_WANT_LIBATA_LEDS=y
> CONFIG_ATA_LEDS=y
> 
> to the target/linux/kirkwood/config-4.4
> 
> but after I made a distclean, recompiled and booted the initramfs image, 
> I can't see any sata trigger
> -------
> root at LEDE:/# cat 
> /sys/devices/platform/gpio-leds/leds/nsa310:green:esata/trigger
> [none] nand-disk timer default-on netdev usbport
> -------
> 
> Does anyone have some ideas on why this does not work?

The ARCH_WANT_LIBATA_LEDS is a hidden symbol which needs to be selected
by the mach code in the kernel. I did this to minimize the risk of the
ledtrig code being included by accident (because it can hurt
performance, at least in theory. In practise in turned out that it
doesn't).
Try adding this patch to target/linux/kirkwood/patches-4.4 in addition
to the changes in target/linux/kirkwood/config-4.4:

--- a/arch/arm/mach-mvebu/Kconfig	2016-12-29 02:45:26.510509646 +0100
+++ b/arch/arm/mach-mvebu/Kconfig	2017-03-08 23:50:16.924096508 +0100
@@ -117,6 +117,7 @@
 config MACH_KIRKWOOD
    bool "Marvell Kirkwood boards"
    depends on ARCH_MULTI_V5
+   select ARCH_WANT_LIBATA_LEDS
    select CPU_FEROCEON
    select GPIOLIB
    select KIRKWOOD_CLK
---

> 
> [1] 
> https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/generic/patches-4.9/834-ledtrig-libata.patch
> 
> -Alberto
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev