[LEDE-DEV] Syslog-ng Makefile typo

[Philip Prindeville]

I was going to submit a fix myself but while you’re making changes...

One thing I did notice is that MUSL does openlog() as a DGRAM socket, but syslog-ng currently opens a STREAM socket (in files/syslog-ng.conf).  Can you please change the unix-stream() to unix-gram() instead?

Thanks.



> On Jan 18, 2017, at 12:35 AM, Milan Kočvara <milankocvara at gmail.com> wrote:
> 
> Hello,
> 
> Sorry for miss and late. Changes bellow. I do not found any other "depracated" function. One question about klogd and syslog-ng kernel messagess. On Linux, the klogd daemon can be used in addition to syslog-ng to read kernel messages and forward them to syslog-ng. klogd used to preprocess kernel messages to resolve symbols and so on, but as this is deprecated by ksymoops there is really no point in running both klogd and syslog-ng in parallel. Also note that running two processes reading /proc/kmsg at the same time might result in dead-locks. < Taken from manpage of syslog-ng. In LEDE/OpenWRT is klogd part of busybox in default.
> 
> Thanks
> 
> 
> --- syslog-ng.conf-orig 2017-01-18 07:36:35.941285583 +0100
> +++ syslog-ng.conf      2017-01-18 08:30:30.416247478 +0100
> @@ -1,4 +1,4 @@
> - at version:3.8
> + at version:3.9
> 
> options {
>        chain_hostnames(no);
> 
> Dne 17.1.2017 v 19:40 Philip Prindeville napsal(a):
>> Actually, I take that back.
>> 
>> Milan, can you please update the top line of files/syslog-ng.conf also?  It needs to read “3.9” instead (assuming there aren’t any syntactic constructs in that file that are now deprecated from 3.8 to 3.9… if there were, the file would need to be updated as well… like when the log_prefix() filter criteria got replaced by program()).
>> 
>> Thanks
>> 
>> 
>>> On Jan 16, 2017, at 1:45 PM, Philip Prindeville <philipp_subx at redfish-solutions.com> wrote:
>>> 
>>> Looks good to me.
>>> 
>>> 
>>>> On Jan 16, 2017, at 4:24 AM, Milan Kočvara <milankocvara at gmail.com> wrote:
>>>> 
>>>> Hello.
>>>> I found typo in syslog-ng makefile.
>>>> 
>>>> I've upgraded to the newest version and I've made correction of the typo. Patch bellow.
>>>> 
>>>> Sorry for bad format of everything. I did it never :)
>>>> 
>>>> --- Makefile-orig       2017-01-16 12:06:44.367684776 +0100
>>>> +++ Makefile~   2017-01-16 12:22:47.198478933 +0100
>>>> @@ -1,14 +1,14 @@
>>>> include  $(TOPDIR)/rules.mk
>>>> 
>>>> PKG_NAME:=syslog-ng
>>>> -PKG_VERSION:=3.8.1
>>>> -PKG_RELEASE:=3
>>>> +PKG_VERSION:=3.9.1
>>>> +PKG_RELEASE:=1
>>>> 
>>>> PKG_MAINTAINER:=W. Michael Petullo <mike at flyn.org>
>>>> 
>>>> PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>>>> PKG_SOURCE_URL:=https://github.com/balabit/syslog-ng/releases/download/$(PKG_NAME)-$(PKG_VERSION)/
>>>> -PKG_MD5SUM:=acf14563cf5ce435db8db35486ce66af
>>>> +PKG_MD5SUM:=1b48da9ef620cf06e55e481b5abb677a
>>>> 
>>>> PKG_INSTALL:=1
>>>> 
>>>> @@ -41,7 +41,7 @@
>>>> CONFIGURE_ARGS += \
>>>>  $(call autoconf_bool,CONFIG_IPV6,ipv6) \
>>>>         --disable-dependency-tracking \
>>>> -         --disable-ampq \
>>>> +         --disable-amqp \
>>>>         --disable-tcp-wrapper \
>>>>         --disable-glibtest \
>>>>         --disable-mongodb \
>>> 
>>> _______________________________________________
>>> Lede-dev mailing list
>>> Lede-dev at lists.infradead.org
>>> http://lists.infradead.org/mailman/listinfo/lede-dev
>