[LEDE-DEV] [PATCH] This patch adds support for the Netgear WN3000RPv3 N300 repeater.

[Rafał Miłecki]

On 17 January 2017 at 23:12,  <hacks at slashdirt.org> wrote:
> From: Thibaut VARENE <hacks at slashdirt.org>
>
> It uses the same trick as for the EX2700 to pass the Second Part
> Magic Check from the bootloader (as described here
> https://forum.openwrt.org/viewtopic.php?pid=312577#p312577 )
>
> Specifications:
> - SoC: MediaTek MT7620A (580MHz, ramips)
> - RAM: 32MB
> - Storage: 8MB NOR SPI flash
> - Wireless: builtin MT7620A
> - Ethernet: 1x100M
>
> Stock firmware is based on OpenWRT Kamikaze snapshot. To install
> LEDE, use the factory.bin image. Once LEDE is installed, subsequent
> updates can use the sysupgrade.bin image.
>
> Signed-off-by: Thibaut VARENE <hacks at slashdirt.org>

Please use "git log target/linux/ramips" to get a hint how patch could
be titled. Something like:
ramips: support for the Netgear WN3000RPv3 N300 repeater
could be more appropriate.


> --- /dev/null
> +++ b/target/linux/ramips/dts/WN3000RPV3.dts
> @@ -0,0 +1,148 @@
> +/dts-v1/;
> +
> +#include "mt7620a.dtsi"
> +
> +#include <dt-bindings/input/input.h>

Please specify license of this file. If possible please choose
something BSD compatible as it may be required for upstreaming it. We
got such request from Florian for Broadcom DTS files:
https://lkml.org/lkml/2016/5/4/707

You may e.g. choose one of:
1) ISC License
2) BSD 3-clause license
3) BSD 2-clause license
4) Clear BSD license


> +&pinctrl {
> +       state_default: pinctrl0 {
> +               default {
> +                       //  spi refclk: pins 37, 38, 39
> +                       //       uartf: pins 8, 9, 10, 11, 12, 13, 14
> +                       //         i2c: pins 1, 2
> +                       ralink,group = "i2c", "uartf", "spi refclk";
> +                       ralink,function = "gpio";
> +               };
> +       };
> +};

Please use ANSI C comments.