[LEDE-DEV] [PATCH 4/4] x86: Add APU2 LED Driver

Chris Blake chrisrblake93 at gmail.com
Tue Jan 17 10:29:27 PST 2017

On Sat, Jan 14, 2017 at 11:13 AM, Felix Fietkau <nbd at nbd.name> wrote:
> On 2017-01-14 18:04, Chris Blake wrote:
>> On Sat, Jan 14, 2017 at 10:41 AM, Chris Blake <chrisrblake93 at gmail.com> wrote:
>>> On Sat, Jan 14, 2017 at 10:31 AM, Felix Fietkau <nbd at nbd.name> wrote:
>>>> On 2017-01-14 17:20, Chris Blake wrote:
>>>>> The following patch adds LED support for the PC Engines APU2/APU3 board
>>>>> on LEDE.
>>>>> Signed-off-by: Chris Blake <chrisrblake93 at gmail.com>
>>>> Has this driver been submitted for upstream inclusion yet?
>>>> - Felix
>>> Felix,
>>> This driver has not been submitted upstream to the Linux mailing list
>>> at this time.
>>> - Chris B
>> Felix,
>> In regards to upstream it seems this driver in particular, APU2 LED,
>> was submitted upstream at https://patches.linaro.org/patch/80049/
>> previously. While this version of the driver varies slightly (better
>> platform detection), would you still prefer this to be re-submitted in
>> package form? Due to the platform specific code I doubt it would have
>> much luck in the upstream lists.
> Yes, since there doesn't seem to be any progress towards getting this
> merged, please re-submit it in package form.
> Thanks,
> - Felix


I have been working on moving the LED driver to a package, but have
some concerns about implementation. Specifically, this would hit the
same issue I had with the Meraki MR18 LED Driver (NU801) around having
the LEDs/Reset button available during boot. Specifically, this is a
concern as the reset button will be unusable for failsafe mode and the
LEDs will fail to show boot status once system integration [0] is
cleaned up and sent as a later PR.

I was curious if you had any feedback, or ideas to get around this. As
for the other GPIO driver, that should have no issues being packaged.

Chris B

[0]: http://lists.infradead.org/pipermail/lede-dev/2016-October/003535.html

More information about the Lede-dev mailing list