[LEDE-DEV] [PATCH v2] procd: update procd.sh to support both: signal-names and signal-numbers

Etienne Champetier champetier.etienne at gmail.com
Fri Jan 13 10:31:48 PST 2017


2017-01-13 10:12 GMT-08:00 Bastian Bittorf <bb at npl.de>:
> * Etienne Champetier <champetier.etienne at gmail.com> [13.01.2017 19:07]:
>> > A real world example is signal 10, which is BUS on ramips and USR1 on PPC.
>>
>> If we know supporting signal number will lead to bug, why not remove it?
>
> for the moment we should be backward compatible.
> after everybody has changed the calls, we should
> indeed remove signal numbers...
>
> command 'git grep procd_send_signal' shows, that
> only 'odhcpd' is a user, but how many external packages?

It's a month old, so i don't think there is a lot of "external" user if any,
and if there is, pretty sure the maintainer is following this ML

If you really don't want to break backward compatibility now, maybe
add a warning?

>
> bye, bastian



More information about the Lede-dev mailing list