[PATCH] lantiq: fix console print

Martin Blumenstingl martin.blumenstingl at googlemail.com
Thu Jan 5 15:49:40 PST 2017

Hi Hauke,

sorry for the late reply - turns out I didn't have time to look into
this all week until now.

On Wed, Jan 4, 2017 at 11:11 PM, Hauke Mehrtens <hauke at hauke-m.de> wrote:
> The boot loader of many boards provides a kernel boot argument with a
> broken console parameter to the kernel. This will be taken before the
> stdout-path defined in device tree and the serial will not work on this
> board. Multiple boards are affected by this problem, so revert this
> patch for all boards. Later we can remove the boot arguments from the
> device tree again, after the individual board was checked to work.
> This partly reverts this commit:
> commit 4995c64857a09c4cc92238ba0bd52cdb06c4c581
> Author: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
> Date:   Sun Dec 11 21:55:00 2016 +0100
>     lantiq: specify console using stdout-path instead of cmdline argument
nit picking here: your patch actually fixes
6b94234a6598b855573a6516494de8e7d755e944 because I removed the
bootargs in that patch -> the kernel only uses the bootloader's
cmdline if there are no bootargs inside the .dts

your change looks good to me, except for two boards (there might be
more, I don't have access to a computer with a sane operating system
at the momemnt) which are still missing the bootargs:
* ARV4525PW
* ARV8539PW22

both are including danube.dtsi which provided default bootargs for all
danube boards, see [0]
unfortunately I won't be able to send a patch until Sunday (fingers
crossed...), so it'd be awesome if someone else could do this.

thanks for un-breaking things I broke!


[0] https://git.lede-project.org/?p=source.git;a=blobdiff;f=target/linux/lantiq/dts/danube.dtsi;h=f11787f9754c9f6d0a033334bb100944a53ea6fd;hp=37db51245448fa09eb86fa0e70c1c230833db99a;hb=6b94234a6598b855573a6516494de8e7d755e944;hpb=4995c64857a09c4cc92238ba0bd52cdb06c4c581

More information about the Lede-dev mailing list