[LEDE-DEV] [PATCH] musl: update musl to 1.1.16 and switch to download from git
Koen Vandeputte
koen.vandeputte at ncentric.com
Tue Jan 3 03:58:05 PST 2017
On 2017-01-03 10:25, Hannu Nyman wrote:
> On 3.1.2017 0:22, Christian Lamparter wrote:
>> This patch updates musl to 1.1.16 [0] and removes all the
>> backported patches.
>> ...
>> delete mode 100644
>> toolchain/musl/patches/099-Add-format-attribute-to-some-function-declarations.patch
>>
>
> Like I commened on the Github PR 660 about the same version bump, I
> think that the file
> 099-Add-format-attribute-to-some-function-declarations.patch is not
> from musl upstream and should likely not be deleted.
>
> Afaik that is an Openwrt/LEDE specific patch from Hauke instead of
> being a backported genuine upstream patch (although its name starts
> with 0). It was recently renamed from 040-xxx ot 099-xxx, but the file
> originates at
> https://github.com/lede-project/source/commit/be5fcf9fd76a30c8a28a17daf9c3ddcc9c3af0ba
> and I think that it should survive the version bump, or at least its
> removal should be evaluated separately as it has nothing to do with
> 1.1.16
>
Good catch.
I agree.
I renamed the patch to 099- to keep the changes at a minimum during
backporting
, but to be perfect it should be renamed again out of the 0xx series to
avoid any further confusion. (or submitted upstream if applicable?)
Koen
> https://github.com/lede-project/source/pull/660
>
>
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev
--
Koen Vandeputte - Software Developer
koen.vandeputte at ncentric.com | +32499736158
More information about the Lede-dev
mailing list