[LEDE-DEV] [PATCH 04/11] build: image.mk: don't install-images for devices not selected

[Yousong Zhou]

On 1 January 2017 at 20:26, Felix Fietkau <nbd at nbd.name> wrote:
> On 2016-12-31 19:06, Yousong Zhou wrote:
>> On 1 January 2017 at 01:11, Felix Fietkau <nbd at nbd.name> wrote:
>>> On 2016-12-31 18:06, Yousong Zhou wrote:
>>>> This commit tries to fix the following situation
>>>>
>>>>  - CONFIG_TARGET_MULTIPLE_PROFILE is not set
>>>>  - CONFIG_TARGET_sunxi_DEVICE_sun7i-a20-cubieboard2=y
>>>>  - All other devices are not selected
>>>>
>>>> The build system will still try to install-images for those other
>>>> devices as PROFILES and PROFILE has value DEVICE_sun7i-a20-cubieboard2
>>>>
>>>> Signed-off-by: Yousong Zhou <yszhou4tech at gmail.com>
>>> This is wrong and breaks using generic profiles. Please just set
>>> PROFILES:= <name of generic profile> in Device/Default in the sunxi
>>> image makefile.
>>>
>>> - Felix
>>>
>>
>> Am I right that if there is no such generic profile for a target,
>> PROFILES should be set to a non-existent value in Device/Default, just
>> to override what's set in Device/InitProfile?
> Correct, but I'd prefer having a default profile to make it easier for
> users.
>
> - Felix
>

If the default device profile is meant to be used to make a single
image that can run on all device, then in the case of sunxi, it is not
possible at least with regard to uboot.

Or if the default device profile is meant to be selected as the
default just to implicitly enable all other profiles of the same
target/subtarget, then again in the case of sunxi it has the
dependency problem as illustrated above.  Besides, the build system
can already select multiple devices and enable all profiles (devices)
with explicit config symbols.  Can this goal of the default profile be
dropped?

My current understanding is that the profiles/*.mk thing is part of
the old code and is to be replaced with the Device/xxx thing.  Correct
me if I am wrong ;)

The conclusion is that for sunxi at least, I do not know how to make a
default profile or device to make it easier for users.  At the moment
we have the alphabetically first one selected as the default but that
is just a little bit not easy for all other devices' users ;)

                yousong