[LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

Mathias Kresin dev at kresin.me
Fri Feb 3 03:13:37 PST 2017

2017-02-03 11:49 GMT+01:00 Kristian Evensen <kristian.evensen at gmail.com>:
> Hi
> On Fri, Feb 3, 2017 at 11:02 AM, Piotr Dymacz <pepe2k at gmail.com> wrote:
>> Hi Kristian,
>> My two cents: the general convention for board name is to not include
>> the manufacturer name (Sanlinking here).
>> As you can see, (almost) all other boards follow this rule, so please
>> use "d240" instead of "sanlinking-d240" (also for dts filename).
> I have no strong feelings for the manufacturer name, so I will remove
> it if that is what it takes to get the patch accepted. However, I can
> easily imagine a second manufacturer naming their device something
> something D240, so perhaps shortening the name to for example SL- is a
> good compromise between the two?

I'm for using SL-D240. I share Kristians concerns about possible name
collisions in targets supporting a lot of boards like ar71xx and
ramips. Piotr, are fine with SL-D240?

Kristian, if you send a v3, please add some information on how to
install LEDE to the Sanlinking D240 to the commit message. Have a look
at https://git.lede-project.org/fd62fa752bbff9ae5277098152e7960a14d241e1
for a good example how it could look like.


More information about the Lede-dev mailing list