[LEDE-DEV] [PATCH v2] ramips: Add support for Sanlinking D240

Kristian Evensen kristian.evensen at gmail.com
Fri Feb 3 02:49:49 PST 2017


Hi

On Fri, Feb 3, 2017 at 11:02 AM, Piotr Dymacz <pepe2k at gmail.com> wrote:
> Hi Kristian,
>
> My two cents: the general convention for board name is to not include
> the manufacturer name (Sanlinking here).
> As you can see, (almost) all other boards follow this rule, so please
> use "d240" instead of "sanlinking-d240" (also for dts filename).
>

I have no strong feelings for the manufacturer name, so I will remove
it if that is what it takes to get the patch accepted. However, I can
easily imagine a second manufacturer naming their device something
something D240, so perhaps shortening the name to for example SL- is a
good compromise between the two?

-Kristian



More information about the Lede-dev mailing list