[LEDE-DEV] [PATCH] odhcp6c: Replace strerror(errno) with %m

[Florian Fainelli]

Le 12/25/17 à 15:05, Rosen Penev a écrit :
> Reduction of 48 bytes in compiled size. No functional difference.
> 
> -pedantic was removed as %m is a GNU extension.

My 2 cents, I really think your patches are moving us in the wrong
direction, even if all C libraries that are currently supported
implement this extension, this is... a GNU extension, therefore, we
should stay away from it.

This was mentioned before, so I will repeat it here, OpenWrt/LEDE
support building with external C libraries, I spent an enormous amount
of time this year fixing problems discovered doing that, these type of
changes clearly make these types of effort even more of a catch up game,
which is already no fun.

The size savings absolutely do not warrant making such changes across
the board, the cost/reward is not just worth it. If you are so obsessed
with size, I am sure we can find better ways to achieve that by
generalizing the use of LTO or even re-linking programs with just what
they need.
-- 
Florian