[LEDE-DEV] [PATCH] odhcp6c: Replace strerror(errno) with %m
Rosen Penev
rosenp at gmail.com
Mon Dec 25 15:05:13 PST 2017
Reduction of 48 bytes in compiled size. No functional difference.
-pedantic was removed as %m is a GNU extension.
Signed-off-by: Rosen Penev <rosenp at gmail.com>
---
CMakeLists.txt | 2 +-
src/dhcpv6.c | 4 ++--
src/odhcp6c.c | 5 ++---
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index a5b0cb3..c80c32a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -5,7 +5,7 @@ cmake_policy(SET CMP0015 NEW)
project(odhcp6c C)
set(CMAKE_SHARED_LIBRARY_LINK_C_FLAGS "")
set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -std=c99")
-add_definitions(-D_GNU_SOURCE -Wall -Werror -Wextra -pedantic)
+add_definitions(-D_GNU_SOURCE -Wall -Werror -Wextra)
if(${EXT_PREFIX_CLASS})
add_definitions(-DEXT_PREFIX_CLASS=${EXT_PREFIX_CLASS})
diff --git a/src/dhcpv6.c b/src/dhcpv6.c
index 9dce577..0944dd2 100644
--- a/src/dhcpv6.c
+++ b/src/dhcpv6.c
@@ -522,9 +522,9 @@ static void dhcpv6_send(enum dhcpv6_msg type, uint8_t trid[3], uint32_t ecs)
if (sendmsg(sock, &msg, 0) < 0) {
char in6_str[INET6_ADDRSTRLEN];
- syslog(LOG_ERR, "Failed to send DHCPV6 message to %s (%s)",
+ syslog(LOG_ERR, "Failed to send DHCPV6 message to %s (%m)",
inet_ntop(AF_INET6, (const void *)&srv.sin6_addr,
- in6_str, sizeof(in6_str)), strerror(errno));
+ in6_str, sizeof(in6_str)));
}
}
diff --git a/src/odhcp6c.c b/src/odhcp6c.c
index 666af5c..a14c22e 100644
--- a/src/odhcp6c.c
+++ b/src/odhcp6c.c
@@ -255,15 +255,14 @@ int main(_unused int argc, char* const argv[])
init_dhcpv6(ifname, client_options, sol_timeout) ||
ra_init(ifname, &ifid, ra_options, ra_holdoff_interval) ||
script_init(script, ifname)) {
- syslog(LOG_ERR, "failed to initialize: %s", strerror(errno));
+ syslog(LOG_ERR, "failed to initialize: %m");
return 3;
}
if (daemonize) {
openlog("odhcp6c", LOG_PID, LOG_DAEMON); // Disable LOG_PERROR
if (daemon(0, 0)) {
- syslog(LOG_ERR, "Failed to daemonize: %s",
- strerror(errno));
+ syslog(LOG_ERR, "Failed to daemonize: %m");
return 4;
}
--
2.7.4
More information about the Lede-dev
mailing list