[LEDE-DEV] [PATCH] dnsmasq: backport upstream fix for segfault

[Hans Dedecker]

On Thu, Aug 24, 2017 at 8:01 PM, Ash Benz via Lede-dev
<lede-dev at lists.infradead.org> wrote:
> The sender domain has a DMARC Reject/Quarantine policy which disallows
> sending mailing list messages using the original "From" header.
>
> To mitigate this problem, the original message has been wrapped
> automatically by the mailing list software.
>
> ---------- Forwarded message ----------
> From: Ash Benz <ash.benz at bk.ru>
> To: lede-dev at lists.infradead.org
> Cc: Ash Benz <ash.benz at bk.ru>
> Bcc:
> Date: Fri, 25 Aug 2017 02:00:01 +0800
> Subject: [PATCH] dnsmasq: backport upstream fix for segfault
> Signed-off-by: Ash Benz <ash.benz at bk.ru>
> ---
>  ...-segfault-caused-by-early-inclusion-stdio.patch | 27 ++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 package/network/services/dnsmasq/patches/250-fix-segfault-caused-by-early-inclusion-stdio.patch
>
> diff --git a/package/network/services/dnsmasq/patches/250-fix-segfault-caused-by-early-inclusion-stdio.patch b/package/network/services/dnsmasq/patches/250-fix-segfault-caused-by-early-inclusion-stdio.patch
> new file mode 100644
> index 0000000000..f9f6556bc9
> --- /dev/null
> +++ b/package/network/services/dnsmasq/patches/250-fix-segfault-caused-by-early-inclusion-stdio.patch
> @@ -0,0 +1,27 @@
> +From: Christian Hesse <mail at eworm.de>
> +
> +We define some constants in dnsmasq.h, which have an influence on
> +stdio.h. So do not include stdio.h before dnsmasq.h.
> +
> +This fixes a segmentation fault caused by size mismatch for
> +size_t and off_t on systems where these are 4 bytes without
> +large file support.
> +Reported, debugged and tested by Arne Worner <arne_woerner at yahoo.com>.
> +
> +Signed-off-by: Christian Hesse <mail at eworm.de>
> +---
> + src/helper.c | 1 -
> + 1 file changed, 1 deletion(-)
> +
> +diff --git a/src/helper.c b/src/helper.c
> +index 635677e..281cb4a 100644
> +--- a/src/helper.c
> ++++ b/src/helper.c
> +@@ -14,7 +14,6 @@
> +    along with this program.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +-#include <stdio.h>
> + #include "dnsmasq.h"
> +
> + #ifdef HAVE_SCRIPT
> --
> 2.14.1
>
>
>
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev
>
Patch has not yet been accepted by upstream dnsmasq maintainer, I
notice another patch
(http://lists.thekelleys.org.uk/pipermail/dnsmasq-discuss/2017q3/011698.html)
which adds extra checks for the same problem.
Let's wait till a patch has been integrated upstream before backporting it

Hans