[LEDE-DEV] [PATCH v2] toolchain: Rework external toolchain libc selection

[Florian Fainelli]

On 09/07/2016 10:26 AM, Florian Fainelli wrote:
> Make it a choice menu which offers the 3 C libraries we know about: glibc,
> uClibc and musl. While at it, make it possible for the external toolchain libc
> to select USE_GLIBC, USE_UCLIBC or USE_MUSL which is used by several packages
> to conditionally include specific CFLAGS (e.g: iproute2).
> 
> Because USE_GLIBC et al. can now be selected by external toolchains, we need to
> restrict the per-libc menus to check on !EXTERNAL_TOOLCHAIN.
> 
> While at it, make musl the default C library for external toolchain to match
> the internal toolchain.
> 
> Signed-off-by: Florian Fainelli <f.fainelli at gmail.com>
> ---
> Changes in v2:
> 
> - do not make musl broken
> - make musl the default
> 
>  toolchain/Config.in        | 21 ++++++++++++++++++---
>  toolchain/glibc/Config.in  |  2 +-
>  toolchain/uClibc/Config.in |  2 +-
>  3 files changed, 20 insertions(+), 5 deletions(-)
> 
> diff --git a/toolchain/Config.in b/toolchain/Config.in
> index 75dc5361a682..7ec1875862d4 100644
> --- a/toolchain/Config.in
> +++ b/toolchain/Config.in
> @@ -96,17 +96,32 @@ menuconfig EXTERNAL_TOOLCHAIN
>  		default "/opt/cross/powerpc-unknown-linux-gnu"  if powerpc
>  		default "/opt/cross/x86_64-unknown-linux-gnu"   if x86_64
>  
> -	config TOOLCHAIN_LIBC
> -		string

Since this was directly passed down to scripts/ext-toolchain.sh, it
seems like we may need need to assign this value somehow based on the
choice offered below, I will respin a patch doing that.
-- 
Florian