[LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables
John Crispin
john at phrozen.org
Thu Oct 6 07:51:02 PDT 2016
On 06/10/2016 16:44, Bastian Bittorf wrote:
> * Jo-Philipp Wich <jo at mein.io> [06.10.2016 16:35]:
>> removing the dollar signs lets expressions succeed which would otherwise
>> fail - which means it introduces a behavior change.
>
> thanks for showing this. i must repeat myself:
>
> before we merge such cleanups, we should write tests
> and checkers for proving that nothing break.
>
> bye, bastian
@Jan-Tarek: 3rd time i am asking this now and i really would like a
reply. do you runtime test these script changes.
John
>
> _______________________________________________
> Lede-dev mailing list
> Lede-dev at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev
>
More information about the Lede-dev
mailing list