[LEDE-DEV] [PATCH v3 04/13] scripts: $/${} is unnecessary on arithmetic variables

Bastian Bittorf bb at npl.de
Thu Oct 6 07:44:33 PDT 2016


* Jo-Philipp Wich <jo at mein.io> [06.10.2016 16:35]:
> removing the dollar signs lets expressions succeed which would otherwise
> fail - which means it introduces a behavior change.

thanks for showing this. i must repeat myself:

before we merge such cleanups, we should write tests
and checkers for proving that nothing break.

bye, bastian



More information about the Lede-dev mailing list