[LEDE-DEV] [PATCH odhcpd 1/5] config: Support infinite as DHCP pool leasetime value

[Hans Dedecker]

On Thu, Nov 17, 2016 at 11:13 PM, Karl Palsson <karlp at tweak.net.au> wrote:
>
> Hans Dedecker <dedeckeh at gmail.com> wrote:
>> Add support for infinite leasetime value; this can be done by
>> specifying "infinite" as leasetime value which is similar to
>> dnsmasq infinite leasetime support. Specifying "infinite" as
>> leasetime is valid for both the host and dhcp uci sections. A
>> DHCPv4/DHCPv6 assignment is now considered infinite if
>> valid_unil holds the value 0.
>
> Can you specify "0" in uci too? that's a really common way of
> saying never, I've not ever seen a config file that needed the
> word "infinite" before
As I explained in the commit message the keyword "infinite" is used by
dnsmasq to configure infinite leasetime; the value 0 is not is not
interpreted by dnsmasq as infinite as it considers this as an invalid
leasetime as it converts all leasetime values smaller than 120 seconds
to 120 seconds; see handling of --dhcp-range in option.c. Similar to
dnsmasq the odhcpd daemon considers leasetime 0 as invalid as it
converts all leasetime smaller 60 seconds to 60 seconds
>
> Sincerely,
> Karl Palsson