[LEDE-DEV] ar71xx: Fix switch config on Mikrotik RB450/G

João Chaínho joaochainho at gmail.com
Thu Nov 17 14:40:48 PST 2016


Hi Mathias,
Sorry about the malformed patch.
You’re right about the RouterStation Pro. I was wrongly changing it too. It has a different switch config from RB450G.
I will split them and leave the RouterStation Pro unchanged. Please let me test it first before resubmit the patch.
> On 17 Nov 2016, at 21:13, Mathias Kresin <dev at kresin.me> wrote:
> 
> Hey João,
> 
> both patches you have send are whitespace mangled by your mail program and do not apply:
> 
> $ git am LEDE-DEV-ar71xx-enable-serial-console-on-mikrotik-devices.patch
> 
> Applying: ar71xx: enable serial console on mikrotik devices
> error: patch failed: target/linux/ar71xx/patches-4.4/701-MIPS-ath79-add-routerboard-detection.patch:1
> error: target/linux/ar71xx/patches-4.4/701-MIPS-ath79-add-routerboard-detection.patch: patch does not apply
> Patch failed at 0001 ar71xx: enable serial console on mikrotik devices
> 
> Please consider using 'git send-email' to prevent such issues. You can find your broken patches in out patchwork at https://patchwork.ozlabs.org/project/lede/list/?submitter=70405&state=* to test it by yourself.
> 
> 16.11.2016 18:17, João Chaínho:
>> This patch fixes switch initial config on Mikrotik RB450/G
>> Signed-off-by: João Chaínho <joaochainho at gmail.com>
>> ---
>> diff --git a/target/linux/ar71xx/base-files/etc/board.d/02_network b/target/linux/ar71xx/base-files/etc/board.d/02_network
>> index df87c96..daf9495 100755
>> --- a/target/linux/ar71xx/base-files/etc/board.d/02_network
>> +++ b/target/linux/ar71xx/base-files/etc/board.d/02_network
>> @@ -343,13 +343,13 @@ ar71xx_setup_interfaces()
>>        rb-450)
>>                ucidef_set_interfaces_lan_wan "eth1" "eth0"
>>                ucidef_add_switch "switch0" \
>> -                       "0:lan" "1:lan" "2:lan" "3:lan" "5 at eth1"
>> +                       "0:lan:4" "1:lan:3" "2:lan:2" "3:lan:1" "5 at eth1"
>>                ;;
>>        rb-450g|\
>>        routerstation-pro)
>>                ucidef_set_interfaces_lan_wan "eth1" "eth0"
>>                ucidef_add_switch "switch0" \
>> -                       "0 at eth1" "2:lan:3" "3:lan:2" "4:lan:1"
>> +                       "0 at eth1" "1:lan:1" "2:lan:4" "3:lan:3" "4:lan:2"
> 
> You are changing the default switch config for the routerstation-pro as well. Is this tested? It seams to me you're fixing one board and breaking another.
> 
> Mathias




More information about the Lede-dev mailing list