[LEDE-DEV] [PATCH mt76] tx: remove spurious semicolon

Daniel Golle daniel at makrotopia.org
Thu Jul 7 18:24:04 PDT 2016


Remove spurious semicolon resulting in ieee80211_sta_set_buffered()
being always called independent from the result of the expression
evaluated by the preceding if-clause.

Spotted by gcc-6 while attempting to build the driver outside of the
buildroot.

Signed-off-by: Daniel Golle <daniel at makrotopia.org>
---

 tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tx.c b/tx.c
index 05313b6..f13afa2 100644
--- a/tx.c
+++ b/tx.c
@@ -198,7 +198,7 @@ mt76_txq_dequeue(struct mt76_dev *dev, struct mt76_txq *mtxq, bool ps)
 	if (skb) {
 		u8 tid = skb->priority & IEEE80211_QOS_CTL_TID_MASK;
 
-		if (ps && skb_queue_empty(&mtxq->retry_q));
+		if (ps && skb_queue_empty(&mtxq->retry_q))
 			ieee80211_sta_set_buffered(txq->sta, tid, false);
 
 		return skb;
-- 
2.9.0




More information about the Lede-dev mailing list