[LEDE-DEV] [PATCH 3/3] bcm53xx: build factory images for WZR-900DHP series

[Naoki FUKAUMI]

hi

thank you for your review!

On Tue, Dec 20, 2016 at 5:10 PM, Mathias Kresin <dev at kresin.me> wrote:
> Please split the whole block into single Build defines. This way we you can
> reuse the build steps for the WSR-1166DHP/WSR-1166DHP2 for example instead
> of adding the same chain of commands again.
>
> Personally I prefer to prepend the unencrypted tag to the image and encrypt
> only the tag within the image in a next step instead of creating an external
> tag file, encrypt it and prepend it to the image.
>
> Doing it this way, your factory image build code could be something like
> this:
>
> IMAGE/factory-DHP-EU.bin := append-ubi | trx-nand |
> buffalo-wzr-900dhp-header |  buffalo-enc -param a -param b | buffalo-tag
> -param a -param b | buffalo-enc-tag -size $tagsize | mkdhpimg
>
> If the buffalo-tag has a fixed size, it might be more elegant to move the
> size param of buffalo-enc-tag to the Build define.
>
> It's obviously to me that you have way more knowledge about Buffalo factory
> images than I. Therefore I have not set the patches to "changes requested"
> in patchwork yet. Might be possible that I've missed something and the
> outlined way would not work or there isn't any benefit of doing it this way.
>
> Would be great if you could give me a feedback on this.
>
> Mathias

I got (probably) better idea :)

I'll prepare v2 patch.

Regards,