[openwrt/openwrt] realtek: pcs: rtl930x: drop unused and broken function
LEDE Commits
lede-commits at lists.infradead.org
Tue Dec 16 04:38:18 PST 2025
robimarko pushed a commit to openwrt/openwrt.git, branch openwrt-25.12:
https://git.openwrt.org/96c86b2ff12fabc018bda459db636d605ecd7aa7
commit 96c86b2ff12fabc018bda459db636d605ecd7aa7
Author: Jonas Jelonek <jelonek.jonas at gmail.com>
AuthorDate: Fri Dec 12 20:05:52 2025 +0000
realtek: pcs: rtl930x: drop unused and broken function
Drop the unused and broken function rtpcs_930x_sds_clock_wait from the
PCS driver. The proper working variant is already some lines above and
called rtpcs_930x_sds_wait_clock_ready.
Signed-off-by: Jonas Jelonek <jelonek.jonas at gmail.com>
Link: https://github.com/openwrt/openwrt/pull/21146
Signed-off-by: Robert Marko <robimarko at gmail.com>
(cherry picked from commit decc4f6ba808fb8aa469cd4886ffeea1bb86bcda)
---
.../files-6.12/drivers/net/pcs/pcs-rtl-otto.c | 20 --------------------
1 file changed, 20 deletions(-)
diff --git a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
index 8368870b62..def6b445d4 100644
--- a/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
+++ b/target/linux/realtek/files-6.12/drivers/net/pcs/pcs-rtl-otto.c
@@ -966,26 +966,6 @@ static void rtpcs_930x_sds_tx_config(struct rtpcs_ctrl *ctrl, int sds,
rtpcs_sds_write_bits(ctrl, sds, page, 0x18, 15, 12, impedance);
}
-/* Wait for clock ready, this assumes the SerDes is in XGMII mode
- * timeout is in ms
- */
-__always_unused
-static int rtpcs_930x_sds_clock_wait(struct rtpcs_ctrl *ctrl, int timeout)
-{
- u32 v;
- unsigned long start = jiffies;
- unsigned long end = start + (HZ / 1000) * timeout;
-
- do {
- rtpcs_sds_write_bits(ctrl, 2, 0x1f, 0x2, 15, 0, 53);
- v = rtpcs_sds_read_bits(ctrl, 2, 0x1f, 20, 5, 4);
- if (v == 3)
- return 0;
- } while (time_before(jiffies, end));
-
- return 1;
-}
-
__always_unused
static void rtpcs_930x_sds_rxcal_dcvs_manual(struct rtpcs_ctrl *ctrl, u32 sds_num,
u32 dcvs_id, bool manual, u32 dvcs_list[])
More information about the lede-commits
mailing list