[openwrt/openwrt] ipq40xx: dont panic on PSGMII calibration fail

LEDE Commits lede-commits at lists.infradead.org
Wed May 22 08:24:20 PDT 2024


robimarko pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/4a78c46cbd64a69e0ce799d13a3c021260771b83

commit 4a78c46cbd64a69e0ce799d13a3c021260771b83
Author: Robert Marko <robimarko at gmail.com>
AuthorDate: Wed May 22 16:55:51 2024 +0200

    ipq40xx: dont panic on PSGMII calibration fail
    
    Currently, in case that PSGMII calibration fails it will panic the kernel
    which is not ideal and is preventing any debugging to be done.
    
    So, since PGMII calibration failing only means that wired networking wont
    work lets convet the panic() call to dev_error.
    
    Link: https://github.com/openwrt/openwrt/pull/15542
    Signed-off-by: Robert Marko <robimarko at gmail.com>
---
 .../706-net-dsa-qca8k-add-IPQ4019-built-in-switch-support.patch         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/ipq40xx/patches-6.6/706-net-dsa-qca8k-add-IPQ4019-built-in-switch-support.patch b/target/linux/ipq40xx/patches-6.6/706-net-dsa-qca8k-add-IPQ4019-built-in-switch-support.patch
index e0331d28ab..20dd345c69 100644
--- a/target/linux/ipq40xx/patches-6.6/706-net-dsa-qca8k-add-IPQ4019-built-in-switch-support.patch
+++ b/target/linux/ipq40xx/patches-6.6/706-net-dsa-qca8k-add-IPQ4019-built-in-switch-support.patch
@@ -654,7 +654,7 @@ Signed-off-by: Robert Marko <robert.marko at sartura.hr>
 +		}
 +	}
 +
-+	panic("PSGMII work is unstable !!! "
++	dev_err(priv->dev, "PSGMII work is unstable !!! "
 +		"Repeated recalibration attempts did not help(0x%x) !\n",
 +		test_result);
 +




More information about the lede-commits mailing list