[openwrt/openwrt] kernel: leds-gca230718: run through clang-format
LEDE Commits
lede-commits at lists.infradead.org
Mon Dec 23 15:24:58 PST 2024
hauke pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/f6433c58108f7e9edf0a8de017132ac5a9d0c1de
commit f6433c58108f7e9edf0a8de017132ac5a9d0c1de
Author: Rosen Penev <rosenp at gmail.com>
AuthorDate: Sun Oct 6 16:51:49 2024 -0700
kernel: leds-gca230718: run through clang-format
This file does not use a coding style consistent with the kernel. Run
clang-format with the kernel's .clang-format file.
Signed-off-by: Rosen Penev <rosenp at gmail.com>
Link: https://github.com/openwrt/openwrt/pull/16869
Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
---
package/kernel/leds-gca230718/src/leds-gca230718.c | 159 +++++++++++----------
1 file changed, 84 insertions(+), 75 deletions(-)
diff --git a/package/kernel/leds-gca230718/src/leds-gca230718.c b/package/kernel/leds-gca230718/src/leds-gca230718.c
index 194d149970..71c8b983b5 100644
--- a/package/kernel/leds-gca230718/src/leds-gca230718.c
+++ b/package/kernel/leds-gca230718/src/leds-gca230718.c
@@ -17,40 +17,39 @@
#include <linux/mutex.h>
#include <linux/version.h>
-#define GCA230718_MAX_LEDS (4u)
+#define GCA230718_MAX_LEDS (4u)
-#define GCA230718_OPMODE_DISABLED (0x00u)
-#define GCA230718_OPMODE_NO_TOGGLE (0x01u)
-#define GCA230718_OPMODE_TOGGLE_RAMP_CONTROL_DISABLED (0x02u)
-#define GCA230718_OPMODE_TOGGLE_RAMP_CONTROL_ENSABLED (0x03u)
+#define GCA230718_OPMODE_DISABLED (0x00u)
+#define GCA230718_OPMODE_NO_TOGGLE (0x01u)
+#define GCA230718_OPMODE_TOGGLE_RAMP_CONTROL_DISABLED (0x02u)
+#define GCA230718_OPMODE_TOGGLE_RAMP_CONTROL_ENSABLED (0x03u)
-#define GCA230718_1ST_SEQUENCE_BYTE_1 (0x02u)
-#define GCA230718_2ND_SEQUENCE_BYTE_1 (0x01u)
-#define GCA230718_3RD_SEQUENCE_BYTE_1 (0x03u)
+#define GCA230718_1ST_SEQUENCE_BYTE_1 (0x02u)
+#define GCA230718_2ND_SEQUENCE_BYTE_1 (0x01u)
+#define GCA230718_3RD_SEQUENCE_BYTE_1 (0x03u)
-struct gca230718_led
-{
+struct gca230718_led {
enum led_brightness brightness;
struct i2c_client *client;
struct led_classdev ledClassDev;
};
-struct gca230718_private
-{
+struct gca230718_private {
struct mutex lock;
struct gca230718_led leds[GCA230718_MAX_LEDS];
};
-static void gca230718_init_private_led_data(struct gca230718_private* data)
+static void gca230718_init_private_led_data(struct gca230718_private *data)
{
u8 ledIndex;
- for (ledIndex = 0; ledIndex < GCA230718_MAX_LEDS; ledIndex++)
- {
+ for (ledIndex = 0; ledIndex < GCA230718_MAX_LEDS; ledIndex++) {
data->leds[ledIndex].client = NULL;
}
}
-static void gca230718_send_sequence(struct i2c_client *client, u8 byte0, struct gca230718_private* gca230718_privateData)
+static void
+gca230718_send_sequence(struct i2c_client *client, u8 byte0,
+ struct gca230718_private *gca230718_privateData)
{
int status = 0;
u8 ledIndex;
@@ -64,140 +63,150 @@ static void gca230718_send_sequence(struct i2c_client *client, u8 byte0, struct
controlCommand[1] = byte0;
controlCommand[2] = GCA230718_OPMODE_NO_TOGGLE;
/* Byte 3-6 are set below to the brighness value of the individual LEDs */
- controlCommand[7] = 0x01; /* Frequency, doesn't care as long as GCA230718_OPMODE_NO_TOGGLE is used above */
+ controlCommand[7] =
+ 0x01; /* Frequency, doesn't care as long as GCA230718_OPMODE_NO_TOGGLE is used above */
/* Byte 8-11 are set below to the brighness value of the individual LEDs */
controlCommand[12] = 0x87;
- for (ledIndex = 0; ledIndex < GCA230718_MAX_LEDS; ledIndex++)
- {
- controlCommand[3 + ledIndex] = gca230718_privateData->leds[ledIndex].brightness;
- controlCommand[8 + ledIndex] = gca230718_privateData->leds[ledIndex].brightness;
+ for (ledIndex = 0; ledIndex < GCA230718_MAX_LEDS; ledIndex++) {
+ controlCommand[3 + ledIndex] =
+ gca230718_privateData->leds[ledIndex].brightness;
+ controlCommand[8 + ledIndex] =
+ gca230718_privateData->leds[ledIndex].brightness;
}
mutex_lock(&(gca230718_privateData->lock));
- if ((status = i2c_smbus_write_i2c_block_data(client, resetCommandRegister, sizeof(resetCommand), resetCommand)) != 0)
- {
- pr_info("Error %i during call of i2c_smbus_write_i2c_block_data for reset command\n", status);
- }
- else if ((status = i2c_smbus_write_i2c_block_data(client, controlCommandRegister, sizeof(controlCommand), controlCommand)) != 0)
- {
- pr_info("Error %i during call of i2c_smbus_write_i2c_block_data for control command\n", status);
+ if ((status = i2c_smbus_write_i2c_block_data(
+ client, resetCommandRegister, sizeof(resetCommand),
+ resetCommand)) != 0) {
+ pr_info("Error %i during call of i2c_smbus_write_i2c_block_data for reset command\n",
+ status);
+ } else if ((status = i2c_smbus_write_i2c_block_data(
+ client, controlCommandRegister,
+ sizeof(controlCommand), controlCommand)) != 0) {
+ pr_info("Error %i during call of i2c_smbus_write_i2c_block_data for control command\n",
+ status);
}
mutex_unlock(&(gca230718_privateData->lock));
}
-static int gca230718_set_brightness(struct led_classdev *led_cdev, enum led_brightness value)
+static int gca230718_set_brightness(struct led_classdev *led_cdev,
+ enum led_brightness value)
{
- struct gca230718_led* led;
- struct i2c_client* client;
+ struct gca230718_led *led;
+ struct i2c_client *client;
led = container_of(led_cdev, struct gca230718_led, ledClassDev);
client = led->client;
- if (client != NULL)
- {
- struct gca230718_private* gca230718_privateData;
+ if (client != NULL) {
+ struct gca230718_private *gca230718_privateData;
led->brightness = value;
gca230718_privateData = i2c_get_clientdata(client);
- gca230718_send_sequence(client, GCA230718_2ND_SEQUENCE_BYTE_1, gca230718_privateData);
+ gca230718_send_sequence(client, GCA230718_2ND_SEQUENCE_BYTE_1,
+ gca230718_privateData);
}
return 0;
}
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(6,3,0)
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 3, 0)
static int gca230718_probe(struct i2c_client *client)
#else
-static int gca230718_probe(struct i2c_client *client, const struct i2c_device_id *id)
+static int gca230718_probe(struct i2c_client *client,
+ const struct i2c_device_id *id)
#endif
{
int status = 0;
- struct gca230718_private* gca230718_privateData;
+ struct gca230718_private *gca230718_privateData;
pr_info("Enter gca230718_probe for device address %u\n", client->addr);
- gca230718_privateData = devm_kzalloc(&(client->dev), sizeof(struct gca230718_private), GFP_KERNEL);
+ gca230718_privateData = devm_kzalloc(
+ &(client->dev), sizeof(struct gca230718_private), GFP_KERNEL);
- if (gca230718_privateData == NULL)
- {
+ if (gca230718_privateData == NULL) {
pr_info("Error during allocating memory for private data\n");
status = -ENOMEM;
- }
- else
- {
- struct device_node* ledNode;
+ } else {
+ struct device_node *ledNode;
mutex_init(&gca230718_privateData->lock);
gca230718_init_private_led_data(gca230718_privateData);
i2c_set_clientdata(client, gca230718_privateData);
- for_each_child_of_node(client->dev.of_node, ledNode)
- {
+ for_each_child_of_node(client->dev.of_node, ledNode) {
u32 regValue = 0;
- if (of_property_read_u32(ledNode, "reg", ®Value) != 0)
- {
- pr_info("Missing entry \"reg\" in node %s\n", ledNode->name);
- }
- else if (regValue >= GCA230718_MAX_LEDS)
- {
- pr_info("Invalid entry \"reg\" in node %s (%u)\n", ledNode->name, regValue);
- }
- else
- {
- struct led_classdev* ledClassDev = &(gca230718_privateData->leds[regValue].ledClassDev);
+ if (of_property_read_u32(ledNode, "reg", ®Value) !=
+ 0) {
+ pr_info("Missing entry \"reg\" in node %s\n",
+ ledNode->name);
+ } else if (regValue >= GCA230718_MAX_LEDS) {
+ pr_info("Invalid entry \"reg\" in node %s (%u)\n",
+ ledNode->name, regValue);
+ } else {
+ struct led_classdev *ledClassDev =
+ &(gca230718_privateData->leds[regValue]
+ .ledClassDev);
struct led_init_data init_data = {};
- gca230718_privateData->leds[regValue].client = client;
+ gca230718_privateData->leds[regValue].client =
+ client;
init_data.fwnode = of_fwnode_handle(ledNode);
- pr_info("Creating LED for node %s: reg=%u\n", ledNode->name, regValue);
+ pr_info("Creating LED for node %s: reg=%u\n",
+ ledNode->name, regValue);
- ledClassDev->name = of_get_property(ledNode, "label", NULL);
- if (ledClassDev->name == NULL)
- {
+ ledClassDev->name =
+ of_get_property(ledNode, "label", NULL);
+ if (ledClassDev->name == NULL) {
ledClassDev->name = ledNode->name;
}
ledClassDev->brightness = LED_OFF;
ledClassDev->max_brightness = LED_FULL;
- ledClassDev->brightness_set_blocking = gca230718_set_brightness;
-
- if (devm_led_classdev_register_ext(&(client->dev), ledClassDev, &init_data) != 0)
- {
+ ledClassDev->brightness_set_blocking =
+ gca230718_set_brightness;
+
+ if (devm_led_classdev_register_ext(
+ &(client->dev), ledClassDev,
+ &init_data) != 0) {
pr_info("Error during call of devm_led_classdev_register_ext");
}
}
}
}
- if (status == 0)
- {
+ if (status == 0) {
/*
Send full initialization sequence.
Afterwards only GCA230718_2ND_SEQUENCE_BYTE_1 must be send to upddate the brightness values.
*/
- gca230718_send_sequence(client, GCA230718_1ST_SEQUENCE_BYTE_1, gca230718_privateData);
- gca230718_send_sequence(client, GCA230718_2ND_SEQUENCE_BYTE_1, gca230718_privateData);
- gca230718_send_sequence(client, GCA230718_3RD_SEQUENCE_BYTE_1, gca230718_privateData);
+ gca230718_send_sequence(client, GCA230718_1ST_SEQUENCE_BYTE_1,
+ gca230718_privateData);
+ gca230718_send_sequence(client, GCA230718_2ND_SEQUENCE_BYTE_1,
+ gca230718_privateData);
+ gca230718_send_sequence(client, GCA230718_3RD_SEQUENCE_BYTE_1,
+ gca230718_privateData);
}
return status;
}
-#if LINUX_VERSION_CODE >= KERNEL_VERSION(5,18,0)
+#if LINUX_VERSION_CODE >= KERNEL_VERSION(5, 18, 0)
static void gca230718_remove(struct i2c_client *client)
#else
static int gca230718_remove(struct i2c_client *client)
#endif
{
- struct gca230718_private* gca230718_privateData;
+ struct gca230718_private *gca230718_privateData;
gca230718_privateData = i2c_get_clientdata(client);
mutex_destroy(&gca230718_privateData->lock);
gca230718_init_private_led_data(gca230718_privateData);
-#if LINUX_VERSION_CODE < KERNEL_VERSION(5,18,0)
+#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 18, 0)
return 0;
#endif
}
More information about the lede-commits
mailing list