[openwrt/openwrt] realtek: ZyXEL GS1900-48: drop gpio-restart

[LEDE Commits]

svanheule pushed a commit to openwrt/openwrt.git, branch openwrt-24.10:
https://git.openwrt.org/feb7a2a232ade8803920fc56220b77e4f8114301

commit feb7a2a232ade8803920fc56220b77e4f8114301
Author: Sander Vanheule <sander at svanheule.net>
AuthorDate: Sun Feb 20 19:50:38 2022 +0100

    realtek: ZyXEL GS1900-48: drop gpio-restart
    
    GPIO 5 on the RTL8231 is defined reset the system, but fails to actually
    do so. This triggers a kernel a number of warnings and backtrace for
    GPIO pins that can sleep, such as the RTL8231's. Two warnings are
    emitted by libgpiod, and a third warning by gpio-restart itself after it
    fails to restart the system:
    
    [  106.654008] ------------[ cut here ]------------
    [  106.659240] WARNING: CPU: 0 PID: 4279 at drivers/gpio/gpiolib.c:3098 gpiod_set_value+0x7c/0x108
                   [ Stack dump and call trace ]
    [  106.826218] ---[ end trace d1de50b401f5a153 ]---
    [  106.962992] ------------[ cut here ]------------
    [  106.968208] WARNING: CPU: 0 PID: 4279 at drivers/gpio/gpiolib.c:3098 gpiod_set_value+0x7c/0x108
                   [ Stack dump and call trace ]
    [  107.136718] ---[ end trace d1de50b401f5a154 ]---
    [  111.087092] ------------[ cut here ]------------
    [  111.092271] WARNING: CPU: 0 PID: 4279 at drivers/power/reset/gpio-restart.c:46 gpio_restart_notify+0xc0/0xdc
                   [ Stack dump and call trace ]
    [  111.256629] ---[ end trace d1de50b401f5a155 ]---
    
    By removing gpio-restart from this device, we skip the restart-by-GPIO
    attempt and rely only on the watchdog for restarts, which is already the
    de facto behaviour.
    
    Signed-off-by: Sander Vanheule <sander at svanheule.net>
    (cherry picked from commit 2ada95ccdf85f7ff82000dcf028659eb178ea50f)
---
 target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts b/target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts
index c7ddd8313a..f049274889 100644
--- a/target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts
+++ b/target/linux/realtek/dts/rtl8393_zyxel_gs1900-48.dts
@@ -39,11 +39,6 @@
 		gpio-controller;
 	};
 
-	gpio-restart {
-		compatible = "gpio-restart";
-		gpios = <&gpio1 5 GPIO_ACTIVE_LOW>;
-	};
-
 	keys {
 		compatible = "gpio-keys-polled";
 		poll-interval = <20>;