[openwrt/openwrt] wifi-scripts: don't fail on unset PSK

LEDE Commits lede-commits at lists.infradead.org
Fri Dec 13 06:29:14 PST 2024


blogic pushed a commit to openwrt/openwrt.git, branch main:
https://git.openwrt.org/76fabd909e64fe2f6e56e28ded90053d1293b242

commit 76fabd909e64fe2f6e56e28ded90053d1293b242
Author: David Bauer <mail at david-bauer.net>
AuthorDate: Sat Dec 7 14:47:29 2024 +0100

    wifi-scripts: don't fail on unset PSK
    
    Don't fail wireless interface bringup on empty PSK set. This is a valid
    configuration, resulting in a PSK network which can't be connected to.
    It does not fail the bringup of the hostapd process.
    
    Keep failing the interface setup in case a password with invalid length
    is used.
    
    This is also beneficial when intending to configure a PPSK network. It
    allows to create a network where no PPSK is yet set.
    
    Signed-off-by: David Bauer <mail at david-bauer.net>
    Link: https://github.com/openwrt/openwrt/pull/17197
    Signed-off-by: John Crispin <john at phrozen.org>
---
 package/network/config/wifi-scripts/files/lib/netifd/hostapd.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/network/config/wifi-scripts/files/lib/netifd/hostapd.sh b/package/network/config/wifi-scripts/files/lib/netifd/hostapd.sh
index 3285ee4312..080f15d7a6 100644
--- a/package/network/config/wifi-scripts/files/lib/netifd/hostapd.sh
+++ b/package/network/config/wifi-scripts/files/lib/netifd/hostapd.sh
@@ -724,7 +724,7 @@ hostapd_set_bss_options() {
 				append bss_conf "wpa_psk=$key" "$N"
 			elif [ ${#key} -ge 8 ] && [ ${#key} -le 63 ]; then
 				append bss_conf "wpa_passphrase=$key" "$N"
-			elif [ -n "$key" ] || [ -z "$wpa_psk_file" ] || [ -z "$sae_password_file" ]; then
+			elif [ -n "$key" ]; then
 				wireless_setup_vif_failed INVALID_WPA_PSK
 				return 1
 			fi




More information about the lede-commits mailing list