[openwrt/openwrt] realtek: Fix CRC offloading for rtl83xx

LEDE Commits lede-commits at lists.infradead.org
Sat Oct 29 02:19:00 PDT 2022


svanheule pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/f4849c0ab7c4cb29a85667f2c16aaa73bbfa4315

commit f4849c0ab7c4cb29a85667f2c16aaa73bbfa4315
Author: Olliver Schinagl <oliver at schinagl.nl>
AuthorDate: Thu Oct 27 20:53:08 2022 +0200

    realtek: Fix CRC offloading for rtl83xx
    
    In rtl83xx_set_features we set bit 3 to enable, and bit 4 to disable
    checksuming. Looking at rtl93xx_set_features we however see that for
    both enable and disable the same bit is used (bit 4). This can't be
    right, especially as bit 4 for rtl83xx seems to be Collision threshold
    occupying 2 bits. Change this to make this more logical.
    
    Fixes: 9e8d62e42117 ("realtek: enable CRC offloading")
    Signed-off-by: Olliver Schinagl <oliver at schinagl.nl>
---
 target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c b/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c
index f5424bbfa3..be84549b9e 100644
--- a/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c
+++ b/target/linux/realtek/files-5.10/drivers/net/ethernet/rtl838x_eth.c
@@ -2247,7 +2247,7 @@ static int rtl83xx_set_features(struct net_device *dev, netdev_features_t featur
 		if (!(features & NETIF_F_RXCSUM))
 			sw_w32_mask(BIT(3), 0, priv->r->mac_port_ctrl(priv->cpu_port));
 		else
-			sw_w32_mask(0, BIT(4), priv->r->mac_port_ctrl(priv->cpu_port));
+			sw_w32_mask(0, BIT(3), priv->r->mac_port_ctrl(priv->cpu_port));
 	}
 
 	return 0;




More information about the lede-commits mailing list