[openwrt/openwrt] realtek: fix SMP startup

LEDE Commits lede-commits at lists.infradead.org
Sat Oct 1 00:24:34 PDT 2022


svanheule pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/2b12da1313706cdd14791f329899de11ce9a35eb

commit 2b12da1313706cdd14791f329899de11ce9a35eb
Author: Markus Stockhausen <markus.stockhausen at gmx.de>
AuthorDate: Mon Sep 26 08:46:08 2022 +0200

    realtek: fix SMP startup
    
    The scope of the SMP startup structure is wrong. It is created on the
    stack and not as a global variable. This can lead to startup failures.
    
    Fixes: 3f41360eb70c ("realtek: use upstream recommendation for CPU start")
    Signed-off-by: Markus Stockhausen <markus.stockhausen at gmx.de
---
 target/linux/realtek/files-5.10/arch/mips/rtl838x/prom.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/linux/realtek/files-5.10/arch/mips/rtl838x/prom.c b/target/linux/realtek/files-5.10/arch/mips/rtl838x/prom.c
index ae768f9338..3282a9c38f 100644
--- a/target/linux/realtek/files-5.10/arch/mips/rtl838x/prom.c
+++ b/target/linux/realtek/files-5.10/arch/mips/rtl838x/prom.c
@@ -31,6 +31,7 @@ const void *fdt;
 
 #ifdef CONFIG_MIPS_MT_SMP
 extern const struct plat_smp_ops vsmp_smp_ops;
+static struct plat_smp_ops rtl_smp_ops;
 
 static void rtl_init_secondary(void)
 {
@@ -220,8 +221,6 @@ void __init prom_init(void)
 
 #ifdef CONFIG_MIPS_MT_SMP
 	if (cpu_has_mipsmt) {
-		struct plat_smp_ops rtl_smp_ops;
-
 		rtl_smp_ops = vsmp_smp_ops;
 		rtl_smp_ops.init_secondary = rtl_init_secondary;
 		register_smp_ops(&rtl_smp_ops);




More information about the lede-commits mailing list