[openwrt/openwrt] image: fix append-image when building multiple profiles

LEDE Commits lede-commits at lists.infradead.org
Wed Mar 24 22:55:40 GMT 2021


dangole pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/b6c366efa89dcaa96072b0a12a451f873aa90077

commit b6c366efa89dcaa96072b0a12a451f873aa90077
Author: Daniel Golle <daniel at makrotopia.org>
AuthorDate: Wed Mar 24 22:53:23 2021 +0000

    image: fix append-image when building multiple profiles
    
    In case CONFIG_TARGET_MULTI_PROFILE is set, IMG_PREFIX cannot be
    expanded. Use DEVICE_IMG_PREFIX instead and make sure it's defined.
    
    Fixes: 8f89b1ab0f ("image: add 'append-image' build command")
    Signed-off-by: Daniel Golle <daniel at makrotopia.org>
---
 include/image-commands.mk | 2 +-
 include/image.mk          | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/image-commands.mk b/include/image-commands.mk
index ec4f9624f5..2c56ed8d1d 100644
--- a/include/image-commands.mk
+++ b/include/image-commands.mk
@@ -28,7 +28,7 @@ define Build/append-kernel
 endef
 
 define Build/append-image
-	dd if=$(BIN_DIR)/$(IMG_PREFIX)$(if $(PROFILE_SANITIZED),-$(PROFILE_SANITIZED))-$(1) >> $@
+	dd if=$(BIN_DIR)/$(DEVICE_IMG_PREFIX)-$(1) >> $@
 endef
 
 compat_version=$(if $(DEVICE_COMPAT_VERSION),$(DEVICE_COMPAT_VERSION),1.0)
diff --git a/include/image.mk b/include/image.mk
index 8b7b2b9740..76c527a15e 100644
--- a/include/image.mk
+++ b/include/image.mk
@@ -419,7 +419,7 @@ DEFAULT_DEVICE_VARS := \
   CMDLINE UBOOTENV_IN_UBI KERNEL_IN_UBI BLOCKSIZE PAGESIZE SUBPAGESIZE \
   VID_HDR_OFFSET UBINIZE_OPTS UBINIZE_PARTS MKUBIFS_OPTS DEVICE_DTS \
   DEVICE_DTS_CONFIG DEVICE_DTS_DIR DEVICE_DTS_OVERLAY DEVICE_FDT_NUM \
-  SOC BOARD_NAME UIMAGE_MAGIC UIMAGE_NAME \
+  DEVICE_IMG_PREFIX SOC BOARD_NAME UIMAGE_MAGIC UIMAGE_NAME \
   SUPPORTED_DEVICES IMAGE_METADATA KERNEL_ENTRY KERNEL_LOADADDR \
   UBOOT_PATH IMAGE_SIZE \
   DEVICE_COMPAT_VERSION DEVICE_COMPAT_MESSAGE \



More information about the lede-commits mailing list