[openwrt/openwrt] kernel: robustify dependencies in kmod-sound-hda-core

LEDE Commits lede-commits at lists.infradead.org
Sun Mar 21 09:59:07 GMT 2021


aparcar pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/2ba0ab1930bd0f28404835b4393a6c99bcd0196c

commit 2ba0ab1930bd0f28404835b4393a6c99bcd0196c
Author: Tony Ambardar <itugrok at yahoo.com>
AuthorDate: Sat Mar 20 23:30:44 2021 -0700

    kernel: robustify dependencies in kmod-sound-hda-core
    
    Dependency tracking for kmod-sound-hda-core is fragile. Enabling some sound
    codecs (Realtek, Conexant, Sigmatel) implicitly adds a kmod-ledtrig-audio
    dependency, while an enabled kmod-ledtrig-audio can be picked up through
    enabling others (e.g. kmod-sound-hda-intel), and the behaviour can change
    across kernel versions.
    
    As kmod-ledtrig-audio is under 2KB, make it an unconditional dependency.
    
    Fixes: a374b8f19051 ("kernel: 5.10: update sound modules")
    Signed-off-by: Tony Ambardar <itugrok at yahoo.com>
---
 package/kernel/linux/modules/sound.mk | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/package/kernel/linux/modules/sound.mk b/package/kernel/linux/modules/sound.mk
index 2c11d078e1..e43be25bc6 100644
--- a/package/kernel/linux/modules/sound.mk
+++ b/package/kernel/linux/modules/sound.mk
@@ -304,10 +304,7 @@ $(eval $(call KernelPackage,sound-dummy))
 define KernelPackage/sound-hda-core
   SUBMENU:=$(SOUND_MENU)
   TITLE:=HD Audio Sound Core Support
-  DEPENDS:= \
-	+LINUX_5_10&&PACKAGE_kmod-sound-hda-codec-realtek:kmod-ledtrig-audio \
-	+LINUX_5_10&&PACKAGE_kmod-sound-hda-codec-conexant:kmod-ledtrig-audio \
-	+LINUX_5_10&&PACKAGE_kmod-sound-hda-codec-idt:kmod-ledtrig-audio
+  DEPENDS:=+kmod-ledtrig-audio
   KCONFIG:= \
 	CONFIG_SND_HDA_CORE \
 	CONFIG_SND_HDA_HWDEP=y \



More information about the lede-commits mailing list