[openwrt/openwrt] generic: kernel 5.4: fix probe error for AR803x PHYs

LEDE Commits lede-commits at lists.infradead.org
Sun Jun 13 02:32:54 PDT 2021


blocktrron pushed a commit to openwrt/openwrt.git, branch master:
https://git.openwrt.org/c44cefceb3add724c135a4f57209ce66af5d40c9

commit c44cefceb3add724c135a4f57209ce66af5d40c9
Author: David Bauer <mail at david-bauer.net>
AuthorDate: Sat Jun 12 13:12:40 2021 +0200

    generic: kernel 5.4: fix probe error for AR803x PHYs
    
    Atheros PHYs using the at803x driver apart from the AR8031/AR8033 fail
    to probe with kernel 5.4, due to ret in at803x_probe being
    uninitialized.
    
    [    1.403461] Atheros 8035 ethernet: probe of 4ef600c00.ethernet:01
                   failed with error -1066114012
    
    Initialize ret in order to successfully prove the PHYs on kernel 5.4.
    
    Kernel 5.10 is not affected, as the ret is always assigned prior to
    returning.
    
    Tested on OCEDO Koala.
    
    Reported-by: Russell Senior <russell at personaltelco.net>
    Signed-off-by: David Bauer <mail at david-bauer.net>
---
 .../790-net-phy-at803x-select-correct-page-on-config-init.patch         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/generic/backport-5.4/790-net-phy-at803x-select-correct-page-on-config-init.patch b/target/linux/generic/backport-5.4/790-net-phy-at803x-select-correct-page-on-config-init.patch
index c6811736f8..b7e3201fb7 100644
--- a/target/linux/generic/backport-5.4/790-net-phy-at803x-select-correct-page-on-config-init.patch
+++ b/target/linux/generic/backport-5.4/790-net-phy-at803x-select-correct-page-on-config-init.patch
@@ -71,7 +71,7 @@ Signed-off-by: David S. Miller <davem at davemloft.net>
  {
  	struct device *dev = &phydev->mdio.dev;
  	struct at803x_priv *priv;
-+	int ret;
++	int ret = 0;
  
  	priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
  	if (!priv)



More information about the lede-commits mailing list